[PATCH 6/9] streaming_write_entry: propagate streaming errors

When we are streaming an index blob to disk, we store the error from stream_blob_to_fd in the result variable, and then immediately overwrite that with the return value of close. That means we catch errors on close (e.g., problems committing the file to disk), but miss anything which happened

Re: [PATCH 6/9] streaming_write_entry: propagate streaming errors

On Mon, Mar 25, 2013 at 4:22 PM, Jeff King p...@peff.net wrote: diff --git a/entry.c b/entry.c index 17a6bcc..002b2f2 100644 --- a/entry.c +++ b/entry.c @@ -126,8 +126,10 @@ static int streaming_write_entry(struct cache_entry *ce, char *path, fd = open_output_fd(path, ce,

Re: [PATCH 6/9] streaming_write_entry: propagate streaming errors

On Mon, Mar 25, 2013 at 05:35:51PM -0400, Eric Sunshine wrote: On Mon, Mar 25, 2013 at 4:22 PM, Jeff King p...@peff.net wrote: diff --git a/entry.c b/entry.c index 17a6bcc..002b2f2 100644 --- a/entry.c +++ b/entry.c @@ -126,8 +126,10 @@ static int streaming_write_entry(struct

Re: [PATCH 6/9] streaming_write_entry: propagate streaming errors

Jeff King wrote: When we are streaming an index blob to disk, we store the error from stream_blob_to_fd in the result variable, and then immediately overwrite that with the return value of close. Good catch. [...] --- a/entry.c +++ b/entry.c @@ -126,8 +126,10 @@ static int