[PATCH 7/4] submodule: clarify logic in show_submodule_summary

2013-03-22 Thread Jeff King
There are two uses of the left and right commit variables that make it hard to be sure what values they have (both for the reader, and for gcc, which wrongly complains that they might be used uninitialized). The functions starts with a cascading if statement, checking that the input sha1s exist,

Re: [PATCH 7/4] submodule: clarify logic in show_submodule_summary

2013-03-22 Thread Junio C Hamano
Jeff King p...@peff.net writes: There are two uses of the left and right commit variables that make it hard to be sure what values they have (both for the reader, and for gcc, which wrongly complains that they might be used uninitialized). The functions starts with a cascading if statement,