Re: [PATCH 7/8] CodingGuidelines: on comparison

2014-05-02 Thread Junio C Hamano
Jeff King writes: > I meant something even less in-depth. Your message says only "on > comparison", and I did not even know what "this" in your sentence above > would mean until I followed the link. > > There are arguments for writing a conditional as "a < b" rather than > "b > a", or vice ve

Re: [PATCH 7/8] CodingGuidelines: on comparison

2014-05-02 Thread Jeff King
On Fri, May 02, 2014 at 11:18:34AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Wed, Apr 30, 2014 at 02:45:11PM -0700, Junio C Hamano wrote: > > > >> See http://thread.gmane.org/gmane.comp.version-control.git/3903/focus=4126 > >> > >> Signed-off-by: Junio C Hamano > > > > Don't yo

Re: [PATCH 7/8] CodingGuidelines: on comparison

2014-05-02 Thread Junio C Hamano
Jeff King writes: > On Wed, Apr 30, 2014 at 02:45:11PM -0700, Junio C Hamano wrote: > >> See http://thread.gmane.org/gmane.comp.version-control.git/3903/focus=4126 >> >> Signed-off-by: Junio C Hamano > > Don't you often complain about submitters referencing a discussion > in a commit message wi

Re: [PATCH 7/8] CodingGuidelines: on comparison

2014-05-01 Thread Jeff King
On Wed, Apr 30, 2014 at 02:45:11PM -0700, Junio C Hamano wrote: > See http://thread.gmane.org/gmane.comp.version-control.git/3903/focus=4126 > > Signed-off-by: Junio C Hamano Don't you often complain about submitters referencing a discussion in a commit message without providing some context or

[PATCH 7/8] CodingGuidelines: on comparison

2014-04-30 Thread Junio C Hamano
See http://thread.gmane.org/gmane.comp.version-control.git/3903/focus=4126 Signed-off-by: Junio C Hamano --- Documentation/CodingGuidelines | 26 ++ 1 file changed, 26 insertions(+) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 21e427