Re: [PATCH 7/8] write_file: add format attribute

2016-07-08 Thread Jeff King
On Fri, Jul 08, 2016 at 05:12:41AM -0400, Jeff King wrote: > I had also hoped it would help with confusing write_file() > and write_file_buf(), since the former's "..." can make it > match the signature of the latter. But given that the buffer > for write_file_buf() is generally not a string liter

[PATCH 7/8] write_file: add format attribute

2016-07-08 Thread Jeff King
This gives us compile-time checking of our format strings, which is a good thing. I had also hoped it would help with confusing write_file() and write_file_buf(), since the former's "..." can make it match the signature of the latter. But given that the buffer for write_file_buf() is generally not