Re: [PATCH 8/8] git submodule update: Have a dedicated helper for cloning

2015-10-21 Thread Stefan Beller
On Wed, Oct 21, 2015 at 2:23 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> I'd like to counter your argument with quoting code from update_clone >> method: >> >> run_processes_parallel(1, get_next_task, start_failure, >> task_finished, &pp); >> >> if (pp.print_unmatched) { >>

Re: [PATCH 8/8] git submodule update: Have a dedicated helper for cloning

2015-10-21 Thread Junio C Hamano
Stefan Beller writes: > I'd like to counter your argument with quoting code from update_clone > method: > > run_processes_parallel(1, get_next_task, start_failure, > task_finished, &pp); > > if (pp.print_unmatched) { > printf("#unmatched\n"); > return 1; > } > >

Re: [PATCH 8/8] git submodule update: Have a dedicated helper for cloning

2015-10-21 Thread Stefan Beller
On Wed, Oct 21, 2015 at 1:47 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> This introduces a new helper function in git submodule--helper >> which takes care of cloning all submodules, which we want to >> parallelize eventually. >> >> Some tests (such as empty URL, update_mode==none) are

Re: [PATCH 8/8] git submodule update: Have a dedicated helper for cloning

2015-10-21 Thread Junio C Hamano
Stefan Beller writes: > This introduces a new helper function in git submodule--helper > which takes care of cloning all submodules, which we want to > parallelize eventually. > > Some tests (such as empty URL, update_mode==none) are required in the > helper to make the decision for cloning. Thes

[PATCH 8/8] git submodule update: Have a dedicated helper for cloning

2015-10-20 Thread Stefan Beller
This introduces a new helper function in git submodule--helper which takes care of cloning all submodules, which we want to parallelize eventually. Some tests (such as empty URL, update_mode==none) are required in the helper to make the decision for cloning. These checks have been moved into the C