Re: [PATCH Outreachy 1/2] format: create pretty.h file

Оля Тележная writes: > Is it true that I need to fix only one commit message? (a typo > s/futher/further/) > > Do you have any other advises what do I need to change? I thought I mentioned that adding #include to all the current users of "commit.h" is way too noisy.

Re: [PATCH Outreachy 1/2] format: create pretty.h file

Is it true that I need to fix only one commit message? (a typo s/futher/further/) Do you have any other advises what do I need to change? Thanks!

Re: [PATCH Outreachy 1/2] format: create pretty.h file

Jeff King writes: > On Fri, Dec 08, 2017 at 09:40:09AM -0800, Junio C Hamano wrote: > >> I see you've "standardized" to drop "extern" from the declarations >> in the header; I have an impression that our preference however is >> to go in the other direction. > > Can we revisit

Re: [PATCH Outreachy 1/2] format: create pretty.h file

On Fri, Dec 08, 2017 at 09:40:09AM -0800, Junio C Hamano wrote: > I see you've "standardized" to drop "extern" from the declarations > in the header; I have an impression that our preference however is > to go in the other direction. Can we revisit that? I haven't see any compelling reason to

Re: [PATCH Outreachy 1/2] format: create pretty.h file

> I see you've "standardized" to drop "extern" from the declarations > in the header; I have an impression that our preference however is > to go in the other direction. OK, absolutely not a problem, I will return them. Do I need to write "extern" further in function declarations? And why did

Re: [PATCH Outreachy 1/2] format: create pretty.h file

Olga Telezhnaya writes: > archive.c | 1 + > builtin/notes.c | 2 +- > builtin/reset.c | 2 +- > builtin/show-branch.c | 2 +- > combine-diff.c| 1 + > commit.c | 1 + > commit.h | 80

Re: [PATCH Outreachy 1/2] format: create pretty.h file

On Fri, Dec 8, 2017 at 8:21 AM, Olga Telezhnaya wrote: > Create header for pretty.c to make formatting interface more structured. > This is a middle point, this file would be merged futher with other s/futher/further/ > files which contain formatting stuff. > >

Re: [PATCH Outreachy 1/2] format: create pretty.h file

Olga Telezhnaya writes: > -extern void get_commit_format(const char *arg, struct rev_info *); > -extern const char *format_subject(struct strbuf *sb, const char *msg, > - const char *line_separator); > -extern void

[PATCH Outreachy 1/2] format: create pretty.h file

Create header for pretty.c to make formatting interface more structured. This is a middle point, this file would be merged futher with other files which contain formatting stuff. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder