Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-16 Thread Alexander Kuleshov
Isn't the problem one of how are users to discover such magic. Yes it was main reason. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-16 Thread Torsten Bögershausen
One little question, how to better resend it? Just send v2 for the 1/3 or resend all with v2? Or maybe will be better to make one patch from these 3 pathes? Thank you. My personal suggestion would be: Please wait 24 hours to collect feedback from the different time-zones in the world, where

[PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Alexander Kuleshov
This patch introduces new --exclude option for the git add command. We already have core.excludesfile configuration variable which indicates a path to file which contains patterns to exclude. This patch provides ability to pass --exclude option to the git add command to exclude paths from command

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: The commit message is missing the important justification for why this new option is desirable, and why only git-add needs it. I think that is a very good point. I actually do not see why this option is ever needed, in a modern world that has the

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Alexander Kuleshov
Hello All, s /no/not/ ?? Thank you Philip. 2015-03-15 23:51 GMT+06:00 Torsten Bögershausen tbo...@web.de: On 2015-03-15 14.49, Alexander Kuleshov wrote: Thanks for working on Git, some minor remarks/suggestions inline. This patch introduces new --exclude option for the git add command.

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Torsten Bögershausen
On 2015-03-15 18.51, Torsten Bögershausen wrote: OPT_BOOL('A', all, addremove_explicit, N_(add changes from all tracked and untracked files)), +{ OPTION_CALLBACK, 0, exclude, exclude_list, N_(pattern), What does pattern mean ? I was too fast, take that back:

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Philip Oakley
From: Alexander Kuleshov kuleshovm...@gmail.com This patch introduces new --exclude option for the git add command. We already have core.excludesfile configuration variable which indicates a path to file which contains patterns to exclude. This patch provides ability to pass --exclude option

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Torsten Bögershausen
On 2015-03-15 14.49, Alexander Kuleshov wrote: Thanks for working on Git, some minor remarks/suggestions inline. This patch introduces new --exclude option for the git add command. This patch is redundant. Shorter may be: Introduce the --exclude option for git add We already have

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Eric Sunshine
In addition to points raised by Philip and Torsten... On Sun, Mar 15, 2015 at 9:49 AM, Alexander Kuleshov kuleshovm...@gmail.com wrote: add: add new --exclude option to git add No need for redundant to git add, since you already have the add: prefix. This patch introduces new --exclude option

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Philip Oakley
From: Junio C Hamano gits...@pobox.com Eric Sunshine sunsh...@sunshineco.com writes: The commit message is missing the important justification for why this new option is desirable, and why only git-add needs it. I think that is a very good point. I actually do not see why this option is

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Junio C Hamano
Philip Oakley philipoak...@iee.org writes: Maybe He/We would be better off adjusting the documentation such that these 'magic' capabilities are brought out of their hiding places into regular view - e.g. a paragraph within the 'git add' documentation (and/or other commands) showing how such