Re: [PATCH v1] Fix bugs preventing adding updated cache entries to the name hash

2018-03-15 Thread Junio C Hamano
Ben Peart writes: > This 2nd part of the patch was more for code cleanliness. Thanks.

Re: [PATCH v1] Fix bugs preventing adding updated cache entries to the name hash

2018-03-15 Thread Ben Peart
On 3/15/2018 1:58 PM, Junio C Hamano wrote: Ben Peart writes: Update replace_index_entry() to clear the CE_HASHED flag from the new cache entry so that it can add it to the name hash in set_index_entry() OK. diff --git a/read-cache.c b/read-cache.c index

Re: [PATCH v1] Fix bugs preventing adding updated cache entries to the name hash

2018-03-15 Thread Junio C Hamano
Ben Peart writes: > Update replace_index_entry() to clear the CE_HASHED flag from the new cache > entry so that it can add it to the name hash in set_index_entry() OK. > diff --git a/read-cache.c b/read-cache.c > index 977921d90c..bdfa552861 100644 > ---

[PATCH v1] Fix bugs preventing adding updated cache entries to the name hash

2018-03-15 Thread Ben Peart
Update replace_index_entry() to clear the CE_HASHED flag from the new cache entry so that it can add it to the name hash in set_index_entry() Fix refresh_cache_ent() to use the copy_cache_entry() macro instead of memcpy() so that it doesn't incorrectly copy the hash state from the old entry.