Re: [PATCH v1] msvc: fix non-standard escape sequence in source

2018-07-25 Thread Jeff Hostetler
On 7/24/2018 2:13 PM, Beat Bolli wrote: Hi Jeff On 24.07.18 16:42, g...@jeffhostetler.com wrote: From: Jeff Hostetler Replace non-standard "\e" escape sequence with "\x1B". This was already fixed in <20180708144342.11922-4-dev+...@drbeat.li>. Cheers, Beat Thanks for the pointer. I

Re: [PATCH v1] msvc: fix non-standard escape sequence in source

2018-07-24 Thread Beat Bolli
Hi Jeff On 24.07.18 16:42, g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > Replace non-standard "\e" escape sequence with "\x1B". This was already fixed in <20180708144342.11922-4-dev+...@drbeat.li>. Cheers, Beat > > In commit 7a17918c34f4e83982456ffe22d880c3cda5384f a trace

Re: [PATCH v1] msvc: fix non-standard escape sequence in source

2018-07-24 Thread Junio C Hamano
g...@jeffhostetler.com writes: > From: Jeff Hostetler > > Replace non-standard "\e" escape sequence with "\x1B". > > In commit 7a17918c34f4e83982456ffe22d880c3cda5384f a trace message with > several "\e" escape sequences was added. This causes a compiler warning > under MSVC. > > According to

Re: [PATCH v1] msvc: fix non-standard escape sequence in source

2018-07-24 Thread Eric Sunshine
On Tue, Jul 24, 2018 at 10:43 AM wrote: > Replace non-standard "\e" escape sequence with "\x1B". > > In commit 7a17918c34f4e83982456ffe22d880c3cda5384f a trace message with > several "\e" escape sequences was added. This causes a compiler warning > under MSVC. Wrong commit. That code was

[PATCH v1] msvc: fix non-standard escape sequence in source

2018-07-24 Thread git
From: Jeff Hostetler Replace non-standard "\e" escape sequence with "\x1B". In commit 7a17918c34f4e83982456ffe22d880c3cda5384f a trace message with several "\e" escape sequences was added. This causes a compiler warning under MSVC. According to [1], the "\e" sequence is an extension supported