Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-14 Thread Junio C Hamano
Ben Peart writes: >> I think it is OK to make it error only if the old one is set without >> the new one. Then people can have _both_ set to the same value >> during the period in which the topic sails through pu down to next >> down to master, after seeing an failure once while building and >>

Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-14 Thread Ben Peart
On 9/13/2018 6:08 PM, Junio C Hamano wrote: Thomas Gummerer writes: Thanks, I do think this is a good idea. I do however share Ævar's concern in https://public-inbox.org/git/87h8itkz2h@evledraar.gmail.com/. I have TEST_GIT_INDEX_VERSION=4 set in my config.mak since quite a long time,

Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-13 Thread Junio C Hamano
Thomas Gummerer writes: > Thanks, I do think this is a good idea. I do however share Ævar's > concern in https://public-inbox.org/git/87h8itkz2h@evledraar.gmail.com/. > I have TEST_GIT_INDEX_VERSION=4 set in my config.mak since quite a > long time, and had I missed this thread, I would all

Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-13 Thread Thomas Gummerer
On 09/13, Ben Peart wrote: > > > On 9/12/2018 6:31 PM, Thomas Gummerer wrote: > > On 09/12, Ben Peart wrote: > > > Teach get_index_format_default() to support running the test suite > > > with specific index versions. In particular, this enables the test suite > > > to be run using index

Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-13 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Wed, Sep 12 2018, Ben Peart wrote: > >> -GIT_TEST_OE_DELTA_SIZE= exercises the uncomon pack-objects code >> +GIT_TEST_OE_DELTA_SIZE= exercises the uncommon pack-objects code >> path where deltas larger than this limit require extra memory >> allocation for

Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-13 Thread Ævar Arnfjörð Bjarmason
On Wed, Sep 12 2018, Ben Peart wrote: > -GIT_TEST_OE_DELTA_SIZE= exercises the uncomon pack-objects code > +GIT_TEST_OE_DELTA_SIZE= exercises the uncommon pack-objects code > path where deltas larger than this limit require extra memory > allocation for bookkeeping. If re-rolled maybe better

Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-13 Thread Ben Peart
On 9/12/2018 6:31 PM, Thomas Gummerer wrote: On 09/12, Ben Peart wrote: Teach get_index_format_default() to support running the test suite with specific index versions. In particular, this enables the test suite to be run using index version 4 which is not the default so gets less testing.

Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-12 Thread Thomas Gummerer
On 09/12, Ben Peart wrote: > Teach get_index_format_default() to support running the test suite > with specific index versions. In particular, this enables the test suite > to be run using index version 4 which is not the default so gets less testing. I found this commit message slightly

[PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

2018-09-12 Thread Ben Peart
Teach get_index_format_default() to support running the test suite with specific index versions. In particular, this enables the test suite to be run using index version 4 which is not the default so gets less testing. Signed-off-by: Ben Peart --- Notes: Base Ref: v2.19.0 Web-Diff: