Re: [PATCH v1 1/1] check-non-portable-shell.pl: Quoted `wc -l` is not portable

2017-12-11 Thread Junio C Hamano
tbo...@web.de writes: > From: Torsten Bögershausen > > wc -l is used to count the number if lines in test scripts. H, "is used" -> "should not be used", probably. Just say "Use test_line_count instead" and leave the explanation why it is a better thing to use to fb3340a6 ("test-lib: introdu

Re: [PATCH v1 1/1] check-non-portable-shell.pl: Quoted `wc -l` is not portable

2017-12-10 Thread Johannes Schindelin
Hi Torsten, On Sun, 10 Dec 2017, tbo...@web.de wrote: > From: Torsten Bögershausen > > wc -l is used to count the number if lines in test scripts. > $ wc -l Makefile > gives a line like this: > 105 Makefile > while Mac OS has 4 leading spaces: > 105 Makefile > > And this means that shell

[PATCH v1 1/1] check-non-portable-shell.pl: Quoted `wc -l` is not portable

2017-12-10 Thread tboegi
From: Torsten Bögershausen wc -l is used to count the number if lines in test scripts. $ wc -l Makefile gives a line like this: 105 Makefile while Mac OS has 4 leading spaces: 105 Makefile And this means that shell expressions like test "$(wc -l