Re: [PATCH v1 2/2] curl_off_t xcurl_off_t is not portable

2018-10-26 Thread Torsten Bögershausen
On Fri, Oct 26, 2018 at 11:48:38AM +0900, Junio C Hamano wrote: > tbo...@web.de writes: > > > From: Torsten Bögershausen > > > Subject: Re: [PATCH v1 2/2] curl_off_t xcurl_off_t is not portable > > That title is misleading; it sounded as if the are these two >

Re: [PATCH v1 2/2] curl_off_t xcurl_off_t is not portable

2018-10-25 Thread Junio C Hamano
tbo...@web.de writes: > From: Torsten Bögershausen > Subject: Re: [PATCH v1 2/2] curl_off_t xcurl_off_t is not portable That title is misleading; it sounded as if the are these two typedefs and they do not work correctly on some platforms, but that is not what you are doing with the

[PATCH v1 2/2] curl_off_t xcurl_off_t is not portable

2018-10-25 Thread tboegi
From: Torsten Bögershausen Comparing signed and unsigned values is not always portable. When setting DEVELOPER = 1 DEVOPTS = extra-all "gcc (Raspbian 6.3.0-18+rpi1+deb9u1) 6.3.0 20170516" errors out with "comparison is always false due to limited range of data type" "[-Werror=type-limits]"