Re: [PATCH v10 00/21] Convert "git stash" to C builtin

2018-10-16 Thread Thomas Gummerer
On 10/16, Johannes Schindelin wrote: > Hi Thomas, > > On Mon, 15 Oct 2018, Thomas Gummerer wrote: > > > 2: 63f2e0e6f9 ! 2: 2d45985676 strbuf.c: add `strbuf_join_argv()` > > @@ -14,19 +14,17 @@ > > strbuf_setlen(sb, sb->len + sb2->len); > > } > > > > -+const

Re: [PATCH v10 00/21] Convert "git stash" to C builtin

2018-10-16 Thread Johannes Schindelin
Hi Thomas, On Mon, 15 Oct 2018, Thomas Gummerer wrote: > 2: 63f2e0e6f9 ! 2: 2d45985676 strbuf.c: add `strbuf_join_argv()` > @@ -14,19 +14,17 @@ > strbuf_setlen(sb, sb->len + sb2->len); > } > > -+const char *strbuf_join_argv(struct strbuf *buf, > -+

Re: [PATCH v10 00/21] Convert "git stash" to C builtin

2018-10-15 Thread Junio C Hamano
Thomas Gummerer writes: > On 10/15, Paul-Sebastian Ungureanu wrote: >> Hello, >> >> This is a new iteration of `git stash`, based on the last review. >> This iteration fixes some code styling issues, bring some changes >> to `do_push_stash()` and `do_create_stash()` to be closer to API by >>

Re: [PATCH v10 00/21] Convert "git stash" to C builtin

2018-10-15 Thread Thomas Gummerer
On 10/15, Paul-Sebastian Ungureanu wrote: > Hello, > > This is a new iteration of `git stash`, based on the last review. > This iteration fixes some code styling issues, bring some changes > to `do_push_stash()` and `do_create_stash()` to be closer to API by > following Thomas Gummerer's review

[PATCH v10 00/21] Convert "git stash" to C builtin

2018-10-14 Thread Paul-Sebastian Ungureanu
Hello, This is a new iteration of `git stash`, based on the last review. This iteration fixes some code styling issues, bring some changes to `do_push_stash()` and `do_create_stash()` to be closer to API by following Thomas Gummerer's review of last iteration [1]. Also, there were some missing