Re: [PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially in C

Hey Christian, On Sat, Aug 13, 2016 at 1:04 PM, Christian Couder wrote: > On Wed, Aug 10, 2016 at 11:57 PM, Pranit Bauva wrote: >> >> @@ -431,6 +434,244 @@ static int bisect_terms(struct bisect_terms *terms, >> const char **argv, int argc) >> return 0; >> } >> >> +static int bisect_sta

Re: [PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially in C

On Wed, Aug 10, 2016 at 11:57 PM, Pranit Bauva wrote: > > @@ -431,6 +434,244 @@ static int bisect_terms(struct bisect_terms *terms, > const char **argv, int argc) > return 0; > } > > +static int bisect_start(struct bisect_terms *terms, int no_checkout, > + const cha

Re: [PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially in C

Hey Junio, On Sat, Aug 13, 2016 at 12:55 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> + ... >> + /* >> + * Write new start state >> + */ >> + if (write_file(git_path_bisect_start(), "%s\n", start_head.buf)) { > > I think this function has changed its signature recently

Re: [PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially in C

Pranit Bauva writes: > + ... > + /* > + * Write new start state > + */ > + if (write_file(git_path_bisect_start(), "%s\n", start_head.buf)) { I think this function has changed its signature recently. I am planning to tag 2.10-rc0 this weekend, and it may be a good time to reba

[PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially in C

Reimplement the `bisect_start` shell function partially in C and add `bisect-start` subcommand to `git bisect--helper` to call it from git-bisect.sh . The last part is not converted because it calls another shell function. `bisect_start` shell function will be completed after the `bisect_next` she