Re: [PATCH v14 05/16] Refactor write_name_quoted_relative, remove unused params

2013-06-25 Thread Jiang Xin
2013/6/25 Junio C Hamano gits...@pobox.com: Jiang Xin worldhello@gmail.com writes: -static void write_name(const char* name, size_t len) +static void write_name(const char *name) { - write_name_quoted_relative(name, len, prefix, prefix_len, stdout, -

[PATCH v14 05/16] Refactor write_name_quoted_relative, remove unused params

2013-06-24 Thread Jiang Xin
After substitute path_relative() in quote.c with relative_path() from path.c, parameters (such as len and prefix_len) are obsolete in function write_name_quoted_relative(). Remove unused parameters from write_name_quoted_relative() and related functions. Signed-off-by: Jiang Xin

Re: [PATCH v14 05/16] Refactor write_name_quoted_relative, remove unused params

2013-06-24 Thread Junio C Hamano
Jiang Xin worldhello@gmail.com writes: -static void write_name(const char* name, size_t len) +static void write_name(const char *name) { - write_name_quoted_relative(name, len, prefix, prefix_len, stdout, - line_terminator); + + /* turn off prefix, if run