Re: [PATCH v15 04/27] bisect--helper: `bisect_clean_state` shell function in C

2016-11-16 Thread Pranit Bauva
Hey Junio, On Wed, Nov 16, 2016 at 3:10 AM, Junio C Hamano wrote: > > Stephan Beyer writes: > > >> +int bisect_clean_state(void) > >> +{ > >> +int result = 0; > >> + > >> +/* There may be some refs packed during bisection */ > >> +struct

Re: [PATCH v15 04/27] bisect--helper: `bisect_clean_state` shell function in C

2016-11-15 Thread Stephan Beyer
On 11/15/2016 10:40 PM, Junio C Hamano wrote: > Stephan Beyer writes: > >>> +int bisect_clean_state(void) >>> +{ >>> + int result = 0; >>> + >>> + /* There may be some refs packed during bisection */ >>> + struct string_list refs_for_removal = STRING_LIST_INIT_NODUP; >>> +

Re: [PATCH v15 04/27] bisect--helper: `bisect_clean_state` shell function in C

2016-11-15 Thread Junio C Hamano
Stephan Beyer writes: >> +int bisect_clean_state(void) >> +{ >> +int result = 0; >> + >> +/* There may be some refs packed during bisection */ >> +struct string_list refs_for_removal = STRING_LIST_INIT_NODUP; >> +for_each_ref_in("refs/bisect", mark_for_removal,

Re: [PATCH v15 04/27] bisect--helper: `bisect_clean_state` shell function in C

2016-11-15 Thread Stephan Beyer
Hi, On 10/14/2016 04:14 PM, Pranit Bauva wrote: > diff --git a/bisect.c b/bisect.c > index 6f512c2..45d598d 100644 > --- a/bisect.c > +++ b/bisect.c > @@ -1040,3 +1046,40 @@ int estimate_bisect_steps(int all) > > return (e < 3 * x) ? n : n - 1; > } > + > +static int

[PATCH v15 04/27] bisect--helper: `bisect_clean_state` shell function in C

2016-10-14 Thread Pranit Bauva
Reimplement `bisect_clean_state` shell function in C and add a `bisect-clean-state` subcommand to `git bisect--helper` to call it from git-bisect.sh . Using `--bisect-clean-state` subcommand is a measure to port shell function to C so as to use the existing test suite. As more functions are