Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

On Tue, Sep 8, 2015 at 11:50 PM, Junio C Hamano wrote: > Matthieu Moy writes: > This line still looks overlong. Would it help to stop spelling this as a double "a = b = overlong expression" assignment? >>> >>> I'm not sure, I get

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

Ehh, I was only kidding, though... On Wed, Sep 9, 2015 at 10:37 AM, Karthik Nayak wrote: > On Tue, Sep 8, 2015 at 11:50 PM, Junio C Hamano wrote: >> Matthieu Moy writes: >> > This line still looks overlong. Would it

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

Matthieu Moy writes: >>> This line still looks overlong. Would it help to stop spelling this >>> as a double "a = b = overlong expression" assignment? >>> >> >> I'm not sure, I get what you mean. > > I guess > > format =

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

Karthik Nayak writes: >> I am flexible with the terminology, but the point is that I think >> the quoting rules are better be specified _outside_ the description >> of a particular atom, but as a general rule. > > I definitely agree, but like Matthieu said, corrently we

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

Karthik Nayak writes: > diff --git a/Documentation/git-for-each-ref.txt > b/Documentation/git-for-each-ref.txt > index d039f40..c5154bb 100644 > --- a/Documentation/git-for-each-ref.txt > +++ b/Documentation/git-for-each-ref.txt > @@ -128,13 +128,14 @@ color:: > are

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

Junio C Hamano writes: > I am flexible with the terminology, but the point is that I think > the quoting rules are better be specified _outside_ the description > of a particular atom, but as a general rule. I agree, but for now we have only one %($open) ... %(end) pair, so

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

Karthik Nayak writes: > On Mon, Sep 7, 2015 at 12:03 PM, Junio C Hamano wrote: >>> diff --git a/builtin/tag.c b/builtin/tag.c >>> index 9fa1400..f55dfda 100644 >>> --- a/builtin/tag.c >>> +++ b/builtin/tag.c >>> @@ -43,8 +43,8 @@ static int

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

On Mon, Sep 7, 2015 at 12:03 PM, Junio C Hamano wrote: > Karthik Nayak writes: > >> diff --git a/Documentation/git-for-each-ref.txt >> b/Documentation/git-for-each-ref.txt >> index d039f40..c5154bb 100644 >> --- a/Documentation/git-for-each-ref.txt >>

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

On Mon, Sep 7, 2015 at 7:35 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> On Mon, Sep 7, 2015 at 12:03 PM, Junio C Hamano wrote: diff --git a/builtin/tag.c b/builtin/tag.c index 9fa1400..f55dfda 100644

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

Karthik Nayak writes: > @@ -705,9 +719,12 @@ static void grab_sub_body_contents(struct atom_value > *val, int deref, struct obj > v->s = xstrdup(subpos); > else if (skip_prefix(name, "contents:lines=", )) { >

Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

On Mon, Sep 7, 2015 at 12:19 AM, Matthieu Moy wrote: > Karthik Nayak writes: > >> @@ -705,9 +719,12 @@ static void grab_sub_body_contents(struct atom_value >> *val, int deref, struct obj >> v->s = xstrdup(subpos); >>

[PATCH v16 00/14] port tag.c to use ref-filter APIs

Version 15 can be found here: http://thread.gmane.org/gmane.comp.version-control.git/277012 Changes in this version: * Grammatical changes. * rename cb_data to at_end_data. * rename align_handler() to end_align_handler() and move it next to align_atom_handler(). * introduce match_atom_name() for