Hi Martin,
On Fri, 23 Nov 2018, Martin Ågren wrote:
> On Fri, 23 Nov 2018 at 11:13, Johannes Schindelin
> wrote:
> > On Mon, 30 Oct 2017, Pranit Bauva wrote:
> >
> > > On Fri, Oct 27, 2017 at 10:58 PM, Martin Ågren
> > > wrote:
> > > > On 27 October 2017 at 17:06, Pranit Bauva
> > > >
On Fri, 23 Nov 2018 at 11:13, Johannes Schindelin
wrote:
> On Mon, 30 Oct 2017, Pranit Bauva wrote:
>
> > On Fri, Oct 27, 2017 at 10:58 PM, Martin Ågren
> > wrote:
> > > On 27 October 2017 at 17:06, Pranit Bauva wrote:
> > >> +static void free_terms(struct bisect_terms *terms)
> > >> +{
> > >>
Hi Pranit,
(Cc:ing Tanushree because they will try to pick up this patch series as
part of the Outreachy program.)
On Mon, 30 Oct 2017, Pranit Bauva wrote:
> On Fri, Oct 27, 2017 at 10:58 PM, Martin Ågren wrote:
> > On 27 October 2017 at 17:06, Pranit Bauva wrote:
> >> +static void
On 27/10/17 16:06, Pranit Bauva wrote:
> Reimplement the `bisect_write` shell function in C and add a
> `bisect-write` subcommand to `git bisect--helper` to call it from
> git-bisect.sh
>
> Using `--bisect-write` subcommand is a temporary measure to port shell
> function in C so as to use the
Hey Junio,
On Fri, Oct 27, 2017 at 11:49 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> - bisect_write "$state" "$rev"
>> + git bisect--helper --bisect-write "$state" "$rev" "$TERM_GOOD"
>> "$TERM_BAD" || exit
>
> I can
Hey Martin,
On Fri, Oct 27, 2017 at 10:58 PM, Martin Ågren wrote:
> On 27 October 2017 at 17:06, Pranit Bauva wrote:
>> +static void free_terms(struct bisect_terms *terms)
>> +{
>> + if (!terms->term_good)
>> + free((void *)
On 10/30/2017 02:38 PM, Stephan Beyer wrote:
> This last change is not necessary. You never use "res".
Whoops, ignore this!
I compared old and new diff and mixed something up, it seems.
Sorry,
Stephan
Also just a minor in addition to the others:
> @@ -153,9 +241,10 @@ int cmd_bisect__helper(int argc, const char **argv,
> const char *prefix)
> WRITE_TERMS,
> BISECT_CLEAN_STATE,
> CHECK_EXPECTED_REVS,
> - BISECT_RESET
> +
Pranit Bauva writes:
> - bisect_write "$state" "$rev"
> + git bisect--helper --bisect-write "$state" "$rev" "$TERM_GOOD"
> "$TERM_BAD" || exit
I can see why two extra "terms" parameters need to be passed to this
helper at this step; looking at
On 27 October 2017 at 17:06, Pranit Bauva wrote:
> +static void free_terms(struct bisect_terms *terms)
> +{
> + if (!terms->term_good)
> + free((void *) terms->term_good);
> + if (!terms->term_bad)
> + free((void *) terms->term_bad);
Reimplement the `bisect_write` shell function in C and add a
`bisect-write` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--bisect-write` subcommand is a temporary measure to port shell
function in C so as to use the existing test suite. As more functions
are ported,
11 matches
Mail list logo