Re: [PATCH v2] blame: add support for --[no-]progress option

2015-11-22 Thread Junio C Hamano
Edmundo Carmona Antoranz writes: > Will also affect annotate Is that a good thing? In any case, make it understandable without the title line (i.e. make it a full sentence, ending with a full stop). > + if (progress) { > +

Re: [PATCH v2] blame: add support for --[no-]progress option

2015-11-22 Thread Edmundo Carmona Antoranz
Nice to see you back, Junio! On Sun, Nov 22, 2015 at 8:08 PM, Junio C Hamano wrote: > Edmundo Carmona Antoranz writes: > >> Will also affect annotate > > Is that a good thing? In any case, make it understandable without > the title line (i.e. make it a

[PATCH v2] blame: add support for --[no-]progress option

2015-11-22 Thread Edmundo Carmona Antoranz
Will also affect annotate Signed-off-by: Edmundo Carmona Antoranz --- Documentation/blame-options.txt | 7 +++ Documentation/git-blame.txt | 9 - builtin/blame.c | 25 +++-- 3 files changed, 38 insertions(+), 3

Re: [PATCH v2] blame: add support for --[no-]progress option

2015-11-22 Thread Johannes Sixt
Am 22.11.2015 um 17:02 schrieb Edmundo Carmona Antoranz: Will also affect annotate Signed-off-by: Edmundo Carmona Antoranz --- Documentation/blame-options.txt | 7 +++ Documentation/git-blame.txt | 9 - builtin/blame.c | 25

Re: [PATCH v2] blame: add support for --[no-]progress option

2015-11-22 Thread Edmundo Carmona Antoranz
Hey, Johannes! An oversight! git-annotate.txt took me to blame-options.txt and I didn't notice it's also pointed to from git-blame.txt. Let's wait for some comments about the coding (or blessings) so that I can send another patch. Thanks! On Sun, Nov 22, 2015 at 1:58 PM, Johannes Sixt