[PATCH v2] convert: legitimately disable clean/smudge filter with an empty override

From: Lars Schneider diff to v1: * improve commit message (Thanks Junio & Torsten) * check for empty filter strings in apply_filter to catch all use cases (Thanks Peff) * use more idiomatic style to check for an empty string (Thanks Eric) * use

[PATCH v2] convert: legitimately disable clean/smudge filter with an empty override

From: Lars Schneider If the clean/smudge command of a Git filter driver (filter..smudge and filter..clean) is set to an empty string ("") and the filter driver is not required (filter..required=false) then Git will run successfully. However, Git will print an error for

Re: [PATCH v2] convert: legitimately disable clean/smudge filter with an empty override

larsxschnei...@gmail.com writes: > From: Lars Schneider > > If the clean/smudge command of a Git filter driver (filter..smudge and > filter..clean) is set to an empty string ("") and the filter driver is > not required (filter..required=false) then Git will run

Re: [PATCH v2] convert: legitimately disable clean/smudge filter with an empty override

Junio C Hamano writes: > Instead, teach apply_filter() to treat an empty string given as a > filter means the input must be returned as-is without conversion, > and the operation must always succeed. Ugh, that was a non-sentence. Instead, teach apply_filter() to treat an

Re: [PATCH v2] convert: legitimately disable clean/smudge filter with an empty override

> On 29 Jan 2016, at 19:20, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> If the clean/smudge command of a Git filter driver (filter..smudge >> and >> filter..clean) is set to an empty string ("") and