Re: [PATCH v2] http: inform about alternates-as-redirects behavior

2017-03-06 Thread Brandon Williams
smart-http is > much more powerful. > > > ------8<--- > > From: Eric Wong <e...@80x24.org> > > Subject: [PATCH] http: inform about alternates-as-redirects behavior > > This v2 looks fine to me. > > -Peff I know I'm a little late to the party but v2 looks good to me too. I like the change from v1 that only mentions the config option as opposed to listing a value it should be set to. -- Brandon Williams

Re: [PATCH v2] http: inform about alternates-as-redirects behavior

2017-03-04 Thread Jeff King
ants to make a patch. Mostly the reason I didn't do so is that I don't think http-alternates are in common use these days, since smart-http is much more powerful. > --8<--- > From: Eric Wong <e...@80x24.org> > Subject: [PATCH] http: inform about alternates-as-redirects behavior This v2 looks fine to me. -Peff

[PATCH v2] http: inform about alternates-as-redirects behavior

2017-03-04 Thread Eric Wong
Jeff King wrote: > On Sat, Mar 04, 2017 at 06:55:48AM +, Eric Wong wrote: > > Jeff King wrote: > > > The warning itself: > > > > > > > + warning("alternate disabled by > > > > http.followRedirects!=true: %s", > > > > > > feels like it could use