Re: [PATCH v2] log: Read gpg settings for signed commit verification

2013-03-27 Thread Junio C Hamano
Jeff King writes: > On Wed, Mar 27, 2013 at 09:15:58AM -0700, Junio C Hamano wrote: > >> >} >> > - >> > + if (git_gpg_config(var, value, cb) < 0) >> > + return -1; >> >if (grep_config(var, value, cb) < 0) >> >return -1; >> >> Hmph. I do not particularly like the wa

Re: [PATCH v2] log: Read gpg settings for signed commit verification

2013-03-27 Thread Jeff King
On Wed, Mar 27, 2013 at 09:15:58AM -0700, Junio C Hamano wrote: > > } > > - > > + if (git_gpg_config(var, value, cb) < 0) > > + return -1; > > if (grep_config(var, value, cb) < 0) > > return -1; > > Hmph. I do not particularly like the way the call to grep_config(

Re: [PATCH v2] log: Read gpg settings for signed commit verification

2013-03-27 Thread Junio C Hamano
Hans Brigman writes: > Content-Type: multipart/mixed; > boundary="_002_8C726954D36902459248B0627BF2E66F45D70C3E4EAUSP01VMBX10c_" No multipart/anything please. We prefer to see text/plain. In general, please follow Documentation/SubmittingPatches. > From: Jacob Sarvis Missing SP between name

[PATCH v2] log: Read gpg settings for signed commit verification

2013-03-27 Thread Hans Brigman
From: Jacob Sarvis log: Read gpg settings for signed commit verification Commit signature verification fails when alternative gpg.program signs the commit, but gpg attempts to verify the signature. "show --show-signature" and "log --show-signature" do not read the gpg.program setting from git con