Re: [PATCH v2] parse-remote: Remove reference to unused op_prep

2017-02-04 Thread siddharth
On Sat, Feb 04, 2017 at 04:55:45PM +0530, Pranit Bauva wrote: > Hey SIddharth, > > > Subject: parse-remote: Remove reference to unused op_prep > ^ > > Minor nit: after the colon, we generally don't use the word starting > with an uppercase letter which I t

Re: [PATCH v2] parse-remote: Remove reference to unused op_prep

2017-02-04 Thread Pranit Bauva
Hey SIddharth, > Subject: parse-remote: Remove reference to unused op_prep ^ Minor nit: after the colon, we generally don't use the word starting with an uppercase letter which I think can be figured out when you run `git log -p git-parse-remote.sh` On Sa

[PATCH v2] parse-remote: Remove reference to unused op_prep

2017-02-04 Thread Siddharth Kannan
The error_on_missing_default_upstream helper function learned to take op_prep argument with 15a147e618 ("rebase: use @{upstream} if no upstream specified", 2011-02-09), but as of 045fac5845 ("i18n: git-parse-remote.sh: mark strings for translation", 2016-04-19), the argument is no longer used. Re