Re: [PATCH v2] sequencer: require trailing NL in footers

2017-04-26 Thread Johannes Schindelin
Hi Junio, On Tue, 25 Apr 2017, Junio C Hamano wrote: > Jonathan Nieder writes: > > > Jonathan Tan wrote: > > > > [...] > >> --- a/t/t3511-cherry-pick-x.sh > >> +++ b/t/t3511-cherry-pick-x.sh > >> @@ -208,6 +208,20 @@ test_expect_success 'cherry-pick -x -s adds sob even >

Re: [PATCH v2] sequencer: require trailing NL in footers

2017-04-25 Thread Junio C Hamano
Jonathan Nieder writes: > Jonathan Tan wrote: > >> Reported-by: Brian Norris >> Signed-off-by: Jonathan Tan >> --- > [...] >> sequencer.c | 11 +++ >> t/t3511-cherry-pick-x.sh | 14 ++

Re: [PATCH v2] sequencer: require trailing NL in footers

2017-04-25 Thread Jonathan Nieder
Jonathan Tan wrote: > Reported-by: Brian Norris > Signed-off-by: Jonathan Tan > --- [...] > sequencer.c | 11 +++ > t/t3511-cherry-pick-x.sh | 14 ++ > 2 files changed, 25 insertions(+) Reviewed-by:

[PATCH v2] sequencer: require trailing NL in footers

2017-04-25 Thread Jonathan Tan
In commit 967dfd4 ("sequencer: use trailer's trailer layout", 2016-11-29), sequencer was taught to use the same mechanism as interpret-trailers to determine the nature of the trailer of a commit message (referred to as the "footer" in sequencer.c). However, the requirement that a footer end in a