On Thu, Nov 10, 2016 at 02:55:06PM -0800, Junio C Hamano wrote:
> If we ensure that the process is still running, then such a check is
> a good belt-and-suspenders way to catch a breakage in the mechanism
> we choose to ensure it. So probably we can require that the kill in
> the "when finished"
Jeff King writes:
> I do think the test would be a lot more obvious if it confirmed at the
> end of the test that the process was still running, as opposed to
> relying on test_when_finished to check it.
I agree that "check that the process is still running" is a wrong
thing to do in the first p
On Thu, Nov 10, 2016 at 02:30:36PM -0800, Junio C Hamano wrote:
> As everybody knows there is no appropriate timeout value that is
> good for everybody. I wonder if we can replace the sleep 1 with
> something like
>
> ( while sleep 3600; do :; done ) &
>
> so that leaked fd will be kept e
Johannes Schindelin writes:
>> OK. sleep.pid is a reasonable easy-to-access side effect we can
>> observe to make sure that the sleep-one-second merge driver was
>> indeed invoked, which was missing from the earlier round.
>
> No, this is incorrect. The condition that we need to know applies is
Hi all,
On Thu, 10 Nov 2016, Junio C Hamano wrote:
> Andreas Schwab writes:
>
> > Commit 5babb5bdb3 ("t6026-merge-attr: clean up background process at end
> > of test case") added a kill command to clean up after the test, but this
> > can fail if the sleep command exits before the cleanup is e
Andreas Schwab writes:
> Commit 5babb5bdb3 ("t6026-merge-attr: clean up background process at end
> of test case") added a kill command to clean up after the test, but this
> can fail if the sleep command exits before the cleanup is executed.
> Ignore the error from the kill command.
>
> Explicit
Commit 5babb5bdb3 ("t6026-merge-attr: clean up background process at end
of test case") added a kill command to clean up after the test, but this
can fail if the sleep command exits before the cleanup is executed.
Ignore the error from the kill command.
Explicitly check for the existence of the pi
7 matches
Mail list logo
