Re: [PATCH v2] transport-helper: check if the dry-run is supported

2013-05-21 Thread Felipe Contreras
On Tue, May 21, 2013 at 7:47 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Tue, May 21, 2013 at 11:55 AM, Junio C Hamano wrote: >> >>> This sounds like a good thing to do. Perhaps the refspec mapping >>> can be handled the same way as a backend feature so that you do not >>> have

Re: [PATCH v2] transport-helper: check if the dry-run is supported

2013-05-21 Thread Junio C Hamano
Felipe Contreras writes: > On Tue, May 21, 2013 at 11:55 AM, Junio C Hamano wrote: > >> This sounds like a good thing to do. Perhaps the refspec mapping >> can be handled the same way as a backend feature so that you do not >> have to unconditionally disable it in the other patch. > > With my p

Re: [PATCH v2] transport-helper: check if the dry-run is supported

2013-05-21 Thread Felipe Contreras
On Tue, May 21, 2013 at 11:55 AM, Junio C Hamano wrote: > Felipe Contreras writes: > >> Certain remote-helpers (the ones with 'export') would try to push >> regardless. >> >> Obviously this is not what the user wants. >> >> Also, add a check for the 'dry-run' option, so remote-helpers can >> impl

Re: [PATCH v2] transport-helper: check if the dry-run is supported

2013-05-21 Thread Junio C Hamano
Felipe Contreras writes: > Certain remote-helpers (the ones with 'export') would try to push > regardless. > > Obviously this is not what the user wants. > > Also, add a check for the 'dry-run' option, so remote-helpers can > implement it. This sounds like a good thing to do. Perhaps the refspe

[PATCH v2] transport-helper: check if the dry-run is supported

2013-05-20 Thread Felipe Contreras
Certain remote-helpers (the ones with 'export') would try to push regardless. Obviously this is not what the user wants. Also, add a check for the 'dry-run' option, so remote-helpers can implement it. Signed-off-by: Felipe Contreras --- transport-helper.c | 5 + 1 file changed, 5 insertion