Re: [PATCH v2 0/2] avoid bogus "recursion detected in die handler" message

2013-04-23 Thread Erik Faye-Lund
On Tue, Apr 16, 2013 at 9:44 PM, Jeff King wrote: > On Tue, Apr 16, 2013 at 04:13:56PM +0200, Johannes Sixt wrote: > >> > I'm not clear on what you are suggesting. That we protect only the main >> > thread from recursion, or that we drop the check entirely? Or that we >> > implement thread-local s

Re: [PATCH v2 0/2] avoid bogus "recursion detected in die handler" message

2013-04-16 Thread Jeff King
On Tue, Apr 16, 2013 at 05:49:41PM -0700, Jonathan Nieder wrote: > Jeff King wrote: > > > [1/2]: usage: allow pluggable die-recursion checks > > [2/2]: run-command: use thread-aware die_is_recursing routine > > Lovely. This doesn't solve the analagous problem for grep, > index-pack, pack-ob

Re: [PATCH v2 0/2] avoid bogus "recursion detected in die handler" message

2013-04-16 Thread Jonathan Nieder
Jeff King wrote: > [1/2]: usage: allow pluggable die-recursion checks > [2/2]: run-command: use thread-aware die_is_recursing routine Lovely. This doesn't solve the analagous problem for grep, index-pack, pack-objects, preload-index, or bidirectional_transfer_loop, but it doesn't make them w

[PATCH v2 0/2] avoid bogus "recursion detected in die handler" message

2013-04-16 Thread Jeff King
On Tue, Apr 16, 2013 at 04:13:56PM +0200, Johannes Sixt wrote: > > I'm not clear on what you are suggesting. That we protect only the main > > thread from recursion, or that we drop the check entirely? Or that we > > implement thread-local storage for this case without using pthread_once? > > Any