Re: [PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-05 Thread Junio C Hamano
Tay Ray Chuan writes: >> All of the above assumes that showing only the patch and not other >> hints to help situation awareness while making a commit is a useful >> thing in the first place. I am undecided on that point myself. > > Hmm, perhaps such functionality should be off-loaded to a third

Re: [PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-05 Thread Tay Ray Chuan
On Sat, Jun 6, 2015 at 12:03 AM, Junio C Hamano wrote: > Tay Ray Chuan writes: > >> Would it be a good idea to have a --diff-only option to include diff, >> but not status output? Or perhaps a --diff option, while leaving it to >> the user to specify if status output is to be included with >> --n

Re: [PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-05 Thread Junio C Hamano
Tay Ray Chuan writes: > Would it be a good idea to have a --diff-only option to include diff, > but not status output? Or perhaps a --diff option, while leaving it to > the user to specify if status output is to be included with > --no-status, which would open the doors for mixing and matching st

Re: [PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-05 Thread Tay Ray Chuan
Hi Junio, On Fri, Jun 5, 2015 at 2:39 AM, Junio C Hamano wrote: > > Tay Ray Chuan writes: > > > When running git-commit`, --verbose appends a diff to the prepared > > message, while --no-status omits git-status output. > > The --verbose option is called --verbose and not --diff or --patch > for

Re: [PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-04 Thread Junio C Hamano
Tay Ray Chuan writes: > When running git-commit`, --verbose appends a diff to the prepared > message, while --no-status omits git-status output. The --verbose option is called --verbose and not --diff or --patch for a reason, though. The default is to show extra information as comments, and ver

[PATCH v2 0/2] make commit --verbose work with --no-status

2015-06-04 Thread Tay Ray Chuan
When running git-commit`, --verbose appends a diff to the prepared message, while --no-status omits git-status output; thus, one would expect --verbose --no-status to give a commit message with a diff of the commit without git-status output. However, this is not what happens - the prepared commit