Re: [PATCH v2 0/4] Delete ignore_env member in struct repository

2018-02-27 Thread Stefan Beller
On Tue, Feb 27, 2018 at 1:58 AM, Nguyễn Thái Ngọc Duy wrote: > v2 fixes the incorrect use of consecutive getenv() and adds a comment > to clarify the role of old_gitdir > > Interdiff: > > diff --git a/environment.c b/environment.c > index 95de419de8..47c6e31559 100644 > ---

Re: [PATCH v2 0/4] Delete ignore_env member in struct repository

2018-02-27 Thread Eric Sunshine
On Tue, Feb 27, 2018 at 4:58 AM, Nguyễn Thái Ngọc Duy wrote: > v2 fixes the incorrect use of consecutive getenv() and adds a comment > to clarify the role of old_gitdir > > diff --git a/environment.c b/environment.c > @@ -148,18 +149,34 @@ static char *expand_namespace(const

[PATCH v2 0/4] Delete ignore_env member in struct repository

2018-02-27 Thread Nguyễn Thái Ngọc Duy
v2 fixes the incorrect use of consecutive getenv() and adds a comment to clarify the role of old_gitdir Interdiff: diff --git a/environment.c b/environment.c index 95de419de8..47c6e31559 100644 --- a/environment.c +++ b/environment.c @@ -14,6 +14,7 @@ #include "fmt-merge-msg.h" #include