Re: [PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-08 Thread Jeff Hostetler
On 11/7/2017 7:54 PM, Junio C Hamano wrote: Jonathan Tan writes: I can see some use for this parameter - for example, when doing a report for statistical purposes (percentage of objects missing, for example) or for a background task that downloads missing objects

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-07 Thread Junio C Hamano
Jonathan Tan writes: > I can see some use for this parameter - for example, when doing a report > for statistical purposes (percentage of objects missing, for example) or > for a background task that downloads missing objects into a cache. Also, > power users who know

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-07 Thread Jonathan Tan
On Fri, 3 Nov 2017 14:34:39 -0400 Jeff Hostetler wrote: > > Assuming we eventually get promisor support working, would there be > > any use case where "any missing is OK" mode would be useful in a > > sense more reasonable than "because we could have such a mode" and > >

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-03 Thread Jeff Hostetler
On 11/3/2017 11:05 AM, Junio C Hamano wrote: Jeff Hostetler writes: Yes, I thought we should have both (perhaps renamed or combined into 1 parameter with value, such as --exclude=missing vs --exclude=promisor) and let the user decide how strict they want to be.

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-03 Thread Junio C Hamano
Jeff Hostetler writes: > Yes, I thought we should have both (perhaps renamed or combined > into 1 parameter with value, such as --exclude=missing vs --exclude=promisor) > and let the user decide how strict they want to be. Assuming we eventually get promisor support

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-03 Thread Jeff Hostetler
On 11/2/2017 3:44 PM, Jonathan Tan wrote: On Thu, 2 Nov 2017 17:50:07 + Jeff Hostetler wrote: From: Jeff Hostetler Here is V2 of the list-object filtering. It replaces [1] and reflect a refactoring and simplification of the original.

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-02 Thread Jonathan Tan
On Thu, 2 Nov 2017 17:50:07 + Jeff Hostetler wrote: > From: Jeff Hostetler > > Here is V2 of the list-object filtering. It replaces [1] > and reflect a refactoring and simplification of the original. Thanks, overall this looks quite good. I

[PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Here is V2 of the list-object filtering. It replaces [1] and reflect a refactoring and simplification of the original. After much discussion on the "list-object-filter-map" I've replaced it with a regular oidset -- the only need for the map was to