Re: [PATCH v2 0/6] shallow.c improvements

2016-12-07 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Dec 6, 2016 at 8:42 PM, Jeff King wrote: >> The final one _seems_ reasonable after reading your explanation, but I >> lack enough context to know whether or not there might be a corner case >> that you're missing. I'm inclined to trust your assessment on it. > > Yeah

Re: [PATCH v2 0/6] shallow.c improvements

2016-12-06 Thread Duy Nguyen
On Tue, Dec 6, 2016 at 8:42 PM, Jeff King wrote: > The final one _seems_ reasonable after reading your explanation, but I > lack enough context to know whether or not there might be a corner case > that you're missing. I'm inclined to trust your assessment on it. Yeah I basically just wrote down

[PATCH v2 0/6] shallow.c improvements

2016-12-06 Thread Nguyễn Thái Ngọc Duy
After staring not-so-hard and not-for-so-long at the code. This is what I come up with. Rasmus I replaced two of your commits with my own (and thank you for giving me an opportunity to refresh my memory with this stuff). The first two commits are new and the result of Jeff's observation on COMMIT_S

Re: [PATCH v2 0/6] shallow.c improvements

2016-12-06 Thread Jeff King
On Tue, Dec 06, 2016 at 07:53:33PM +0700, Nguyễn Thái Ngọc Duy wrote: > Nguyễn Thái Ngọc Duy (4): > shallow.c: rename fields in paint_info to better express their purposes > shallow.c: stop abusing COMMIT_SLAB_SIZE for paint_info's memory pools > shallow.c: make paint_alloc slightly more rob