Re: [PATCH v2 0/8] Clarify commit-graph and grafts/replace/shallow incompatibilities

2018-08-21 Thread Derrick Stolee
On 8/21/2018 1:51 PM, Junio C Hamano wrote: Stefan Beller writes: On Mon, Aug 20, 2018 at 11:24 AM Derrick Stolee wrote: Because of the change of base, it is hard to provide a side-by-side diff from v1. I thought that was the whole point of range-diff. ;-) I thought so, too. Was there

Re: [PATCH v2 0/8] Clarify commit-graph and grafts/replace/shallow incompatibilities

2018-08-21 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Aug 20, 2018 at 11:24 AM Derrick Stolee wrote: >> Because of the change of base, it is hard to provide a side-by-side diff >> from v1. > > I thought that was the whole point of range-diff. ;-) I thought so, too. Was there any change that confused range-diff

Re: [PATCH v2 0/8] Clarify commit-graph and grafts/replace/shallow incompatibilities

2018-08-20 Thread Derrick Stolee
On 8/20/2018 3:37 PM, Stefan Beller wrote: On Mon, Aug 20, 2018 at 11:24 AM Derrick Stolee wrote: One unresolved issue with the commit-graph feature is that it can cause issues when combined with replace objects, commit grafts, or shallow clones. These are not 100% incompatible, as one could

Re: [PATCH v2 0/8] Clarify commit-graph and grafts/replace/shallow incompatibilities

2018-08-20 Thread Stefan Beller
On Mon, Aug 20, 2018 at 11:24 AM Derrick Stolee wrote: > > One unresolved issue with the commit-graph feature is that it can cause > issues when combined with replace objects, commit grafts, or shallow > clones. These are not 100% incompatible, as one could be reasonably > successful writing a

Re: [PATCH v2 0/8] Clarify commit-graph and grafts/replace/shallow incompatibilities

2018-08-20 Thread Stefan Beller
On Mon, Aug 20, 2018 at 11:24 AM Derrick Stolee wrote: > Because of the change of base, it is hard to provide a side-by-side diff > from v1. I thought that was the whole point of range-diff. ;-) I'll take a look. Thanks, Stefan

[PATCH v2 0/8] Clarify commit-graph and grafts/replace/shallow incompatibilities

2018-08-20 Thread Derrick Stolee
One unresolved issue with the commit-graph feature is that it can cause issues when combined with replace objects, commit grafts, or shallow clones. These are not 100% incompatible, as one could be reasonably successful writing a commit-graph after replacing some objects and not have issues. The