Re: [PATCH v2 0/9] Keep git clean -d from inadvertently removing ignored files

2017-05-08 Thread Junio C Hamano
Samuel Lijin writes: > What happens right now is that because (1) directories containing only > untracked and ignored files are considered "untracked" and (2) > read_directory_recursive() skips over untracked directories, even with > DIR_SHOW_IGNORED_TOO set. As a result, `status --ignored` never

Re: [PATCH v2 0/9] Keep git clean -d from inadvertently removing ignored files

2017-05-08 Thread Samuel Lijin
On Sun, May 7, 2017 at 11:26 PM, Junio C Hamano wrote: > Samuel Lijin writes: > >> Addresses the issues raised by Stefan and Junio (thanks for your >> feedback) about not using C99-style comments and keeping tests >> working on every commit to prevent breaking git bisect. (About the >> latter one

Re: [PATCH v2 0/9] Keep git clean -d from inadvertently removing ignored files

2017-05-07 Thread Junio C Hamano
Samuel Lijin writes: > Addresses the issues raised by Stefan and Junio (thanks for your > feedback) about not using C99-style comments and keeping tests > working on every commit to prevent breaking git bisect. (About the > latter one: is it necessary to prevent compiler warnings, in > addition t

[PATCH v2 0/9] Keep git clean -d from inadvertently removing ignored files

2017-05-06 Thread Samuel Lijin
Addresses the issues raised by Stefan and Junio (thanks for your feedback) about not using C99-style comments and keeping tests working on every commit to prevent breaking git bisect. (About the latter one: is it necessary to prevent compiler warnings, in addition to compiler errors? Because if