Re: [PATCH v2 00/10] Use a structure for object IDs.

2015-03-14 Thread brian m. carlson
On Fri, Mar 13, 2015 at 11:39:26PM +, brian m. carlson wrote: Changes since v1: I just realized that I sent this out as v2 instead of v3. It really is v3. My apologies for the error. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 |

Re: [PATCH v2 00/10] Use a structure for object IDs.

2015-03-13 Thread brian m. carlson
On Wed, Mar 11, 2015 at 01:35:06PM -0700, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: 4. We continue to support working with SHA-1s declared to be (unsigned char *) in some performance-critical code, even as we migrate most other code to using SHA-1s embedded within a

[PATCH v2 00/10] Use a structure for object IDs.

2015-03-13 Thread brian m. carlson
This is a patch series to convert some of the relevant uses of unsigned char [20] to struct object_id. The goal of this series to improve type-checking in the codebase and to make it easier to move to a different hash function if the project decides to do that. There should be no functional

Re: [PATCH v2 00/10] Use a structure for object IDs.

2015-03-12 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: I think this is a really interesting project and I hope that it works out. Count me in ;-) In my opinion, the biggest risk (aside from the sheer amount of work required) is the issue that was brought up on the mailing list when you submitted v1

Re: [PATCH v2 00/10] Use a structure for object IDs.

2015-03-11 Thread Michael Haggerty
On 03/08/2015 12:23 AM, brian m. carlson wrote: This is a patch series to convert some of the relevant uses of unsigned char [20] to struct object_id. The goal of this series to improve type-checking in the codebase and to make it easier to move to a different hash function if the project

Re: [PATCH v2 00/10] Use a structure for object IDs.

2015-03-10 Thread Kyle J. McKay
On Mar 7, 2015, at 15:23, brian m. carlson wrote: This is a patch series to convert some of the relevant uses of unsigned char [20] to struct object_id. brian m. carlson (10): All patches applied for me (to master) and all tests pass. Tested-by: Kyle J. McKay Define a structure for

Re: [PATCH v2 00/10] Use a structure for object IDs.

2015-03-07 Thread Junio C Hamano
brian m. carlson sand...@crustytoothpaste.net writes: Certain parts of the code have to be converted before others to keep the patch sizes small, maintainable, and bisectable, so functions and structures that are used across the codebase (e.g. struct object) will be converted later.

[PATCH v2 00/10] Use a structure for object IDs.

2015-03-07 Thread brian m. carlson
This is a patch series to convert some of the relevant uses of unsigned char [20] to struct object_id. The goal of this series to improve type-checking in the codebase and to make it easier to move to a different hash function if the project decides to do that. This series does not convert all