Re: [PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-31 Thread Junio C Hamano
Jeff King writes: > On Mon, Jul 31, 2017 at 07:44:27PM +0200, Martin Ågren wrote: > >> On 31 July 2017 at 05:46, Jeff King wrote: >> > On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote: >> > >> >> On 21 July 2017 at 00:27, Junio C Hamano

Re: [PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-31 Thread Martin Ågren
On 31 July 2017 at 05:46, Jeff King wrote: > On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote: > >> On 21 July 2017 at 00:27, Junio C Hamano wrote: >> > I tend to agree with you that 1-3/10 may be better off being a >> > single patch (or 3/10

Re: [PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-31 Thread Jeff King
On Mon, Jul 31, 2017 at 07:44:27PM +0200, Martin Ågren wrote: > On 31 July 2017 at 05:46, Jeff King wrote: > > On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote: > > > >> On 21 July 2017 at 00:27, Junio C Hamano wrote: > >> > I tend to agree with you

Re: [PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-30 Thread Jeff King
On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote: > On 21 July 2017 at 00:27, Junio C Hamano wrote: > > I tend to agree with you that 1-3/10 may be better off being a > > single patch (or 3/10 dropped, as Brandon is working on losing it > > nearby). I would have

Re: [PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-23 Thread Martin Ågren
On 21 July 2017 at 00:27, Junio C Hamano wrote: > I tend to agree with you that 1-3/10 may be better off being a > single patch (or 3/10 dropped, as Brandon is working on losing it > nearby). I would have expected 7-8/10 to be a single patch, as by > the time a reader reaches

Re: [PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-20 Thread Junio C Hamano
Martin Ågren writes: > This is the second version of "[PATCH 0/7] tag: more fine-grained > pager-configuration" [1]. That series introduced `pager.tag.list` to > address the fact that `pager.tag` can be useful with `git tag -l` but > actively hostile with `git tag -a`.

Re: [PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-18 Thread Junio C Hamano
Martin Ågren writes: > After that feedback, v2 drops `pager.tag.list` and instead teaches > `git tag` to only consider `pager.tag` in list-mode, as suggested by > Peff. That does sound like a more sensible and safer approach. I may have comments on individual patches,

[PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-17 Thread Martin Ågren
This is the second version of "[PATCH 0/7] tag: more fine-grained pager-configuration" [1]. That series introduced `pager.tag.list` to address the fact that `pager.tag` can be useful with `git tag -l` but actively hostile with `git tag -a`. Thanks to Junio, Peff and Brandon for helpful feedback.