Re: [PATCH v2 00/11] git_config callers rewritten with the new config-set API

2014-08-07 Thread Junio C Hamano
Tanay Abhra writes: > 11 files changed, 114 insertions(+), 250 deletions(-) Nice reduction. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 00/11] git_config callers rewritten with the new config-set API

2014-08-07 Thread Matthieu Moy
Tanay Abhra writes: > [v2]: git_die_config() messages changed. Diff between v1 and v2 is at the > bottom. I went through the series once more, and all the changes look good. v3 for PATCH 11/11 addresses my comment about the commit message in v2. Reviewed-by: Matthieu Moy -- Matthieu Moy ht

[PATCH v2 00/11] git_config callers rewritten with the new config-set API

2014-08-07 Thread Tanay Abhra
[v2]: git_die_config() messages changed. Diff between v1 and v2 is at the bottom. The ta/config-set API is more or less solidified. This series builds on the top of 4c715ebb in pu (ta/config-set). On top of it, it also requires series [1] (Rewrite `git_config()` using config-set API) for proper