Re: [PATCH v2 00/14] Some fixes and bunch of object_id conversions

2018-01-22 Thread Patryk Obara
> Patches 1 and 2 should be sent separately though. I hoped they could be piggy-backed, but since there will be v3 of this patch series... I'll wait for Junio's opinion. > I look forward to seeing you deal with the object reading part … Yeah, even reading of loose objects does not work on my tes

Re: [PATCH v2 00/14] Some fixes and bunch of object_id conversions

2018-01-22 Thread Duy Nguyen
On Mon, Jan 22, 2018 at 12:04:23PM +0100, Patryk Obara wrote: > sha1_file.c | 100 > ++ You have started the invasion to sha1_file.c. Victory is near! (*) 2018 will be the year of something-other-shan-sha1 :) I've read through the series

[PATCH v2 00/14] Some fixes and bunch of object_id conversions

2018-01-22 Thread Patryk Obara
Compared to v1: Following brian's suggestion I renamed following functions and struct names to indicate, that they are no longer intended for sha1 algorithm only: struct sha1_stat -> struct oid_stat pretend_sha1_file-> pretend_object_file write_sha1_file -> write_object_f