Re: [PATCH v2 00/16] Make Gnome Credential helper more Gnome-y and support ancient distros

2013-10-16 Thread Junio C Hamano
Brandon Casey writes: > On 10/15/2013 3:40 PM, Junio C Hamano wrote: >> This seems to post-date what Jonathan has kept in his 'pu'; is this >> the latest (I have a huge backlog to wade through, so I'd rather >> skip it if another reroll is coming and move on to other topics). >> >> Thanks. > > T

Re: [PATCH v2 00/16] Make Gnome Credential helper more Gnome-y and support ancient distros

2013-10-15 Thread Brandon Casey
On 10/15/2013 3:40 PM, Junio C Hamano wrote: > This seems to post-date what Jonathan has kept in his 'pu'; is this > the latest (I have a huge backlog to wade through, so I'd rather > skip it if another reroll is coming and move on to other topics). > > Thanks. This is the latest. I didn't have

Re: [PATCH v2 00/16] Make Gnome Credential helper more Gnome-y and support ancient distros

2013-10-15 Thread Junio C Hamano
This seems to post-date what Jonathan has kept in his 'pu'; is this the latest (I have a huge backlog to wade through, so I'd rather skip it if another reroll is coming and move on to other topics). Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message

Re: [PATCH v2 00/16] Make Gnome Credential helper more Gnome-y and support ancient distros

2013-09-23 Thread Jeff King
On Mon, Sep 23, 2013 at 11:49:01AM -0700, Brandon Casey wrote: > Brandon Casey (16): > contrib/git-credential-gnome-keyring.c: remove unnecessary > pre-declarations > [...] Thanks, I think this is a good change. There were patches[1] from Philipp about a year ago that went in the opposite d

Re: [PATCH v2 00/16] Make Gnome Credential helper more Gnome-y and support ancient distros

2013-09-23 Thread Felipe Contreras
On Mon, Sep 23, 2013 at 1:49 PM, Brandon Casey wrote: > From: Brandon Casey > > Mostly unchanged. > > Inserts a patch to fix the style issues for block statements. > i.e. use "if ()" instead of "if()" > > A couple early patches were reordered to improve logical flow. > > Updated the comment in th

[PATCH v2 00/16] Make Gnome Credential helper more Gnome-y and support ancient distros

2013-09-23 Thread Brandon Casey
From: Brandon Casey Mostly unchanged. Inserts a patch to fix the style issues for block statements. i.e. use "if ()" instead of "if()" A couple early patches were reordered to improve logical flow. Updated the comment in the last patch to hopefully improve clarity wrt RHEL 4.X The only functi