Re: [PATCH v2 03/11] tests: at-combinations: improve nonsense()

2013-05-07 Thread Felipe Contreras
On Wed, May 8, 2013 at 12:55 AM, Junio C Hamano wrote: > Felipe Contreras writes: > >> In some circumstances 'git log' might fail, but not because the @ >> parsing failed. For example: 'git rev-parse' might succeed and return a >> bad object, and then 'git log' would fail. >> >> The layer we want

Re: [PATCH v2 03/11] tests: at-combinations: improve nonsense()

2013-05-07 Thread Junio C Hamano
Felipe Contreras writes: > In some circumstances 'git log' might fail, but not because the @ > parsing failed. For example: 'git rev-parse' might succeed and return a > bad object, and then 'git log' would fail. > > The layer we want to test is revision parsing, so let's test that > directly. Hm

[PATCH v2 03/11] tests: at-combinations: improve nonsense()

2013-05-07 Thread Felipe Contreras
In some circumstances 'git log' might fail, but not because the @ parsing failed. For example: 'git rev-parse' might succeed and return a bad object, and then 'git log' would fail. The layer we want to test is revision parsing, so let's test that directly. Signed-off-by: Ramkumar Ramachandra Sig