Re: [PATCH v2 05/14] sequencer: lib'ify do_pick_commit()

2016-08-29 Thread Junio C Hamano
Johannes Schindelin writes: > Instead of dying there, let the caller high up in the callchain notice > the error and handle it (by dying, still). > > The only two callers of do_pick_commit(), pick_commits() and > single_pick() already check the return value and pass

[PATCH v2 05/14] sequencer: lib'ify do_pick_commit()

2016-08-26 Thread Johannes Schindelin
Instead of dying there, let the caller high up in the callchain notice the error and handle it (by dying, still). The only two callers of do_pick_commit(), pick_commits() and single_pick() already check the return value and pass it on to their callers, so their callers must be already prepared to