Re: [PATCH v2 05/18] fsck: Allow demoting errors to warnings via receive.fsck.warn = key

2015-01-22 Thread Johannes Schindelin
Hi Junio, On 2015-01-21 22:47, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: @@ -1488,8 +1501,13 @@ static const char *unpack(int err_fd, struct shallow_info *si) argv_array_pushl(child.args, index-pack, --stdin,

Re: [PATCH v2 05/18] fsck: Allow demoting errors to warnings via receive.fsck.warn = key

2015-01-21 Thread Johannes Schindelin
Hi Junio, On 2015-01-21 09:54, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: +if (starts_with(var, receive.fsck.)) { +if (fsck_severity.len) +strbuf_addch(fsck_severity, ','); +strbuf_addf(fsck_severity, %s=%s,

Re: [PATCH v2 05/18] fsck: Allow demoting errors to warnings via receive.fsck.warn = key

2015-01-21 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: @@ -1488,8 +1501,13 @@ static const char *unpack(int err_fd, struct shallow_info *si) argv_array_pushl(child.args, index-pack, --stdin, hdr_arg, keep_arg, NULL); - if (fsck_objects) -

Re: [PATCH v2 05/18] fsck: Allow demoting errors to warnings via receive.fsck.warn = key

2015-01-21 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: + if (starts_with(var, receive.fsck.)) { + if (fsck_severity.len) + strbuf_addch(fsck_severity, ','); + strbuf_addf(fsck_severity, %s=%s, var + 13, value); Wouldn't it be safer to use

[PATCH v2 05/18] fsck: Allow demoting errors to warnings via receive.fsck.warn = key

2015-01-19 Thread Johannes Schindelin
For example, missing emails in commit and tag objects can be demoted to mere warnings with git config receive.fsck.warn = missing-email The value is actually a comma-separated list, and there is a corresponding receive.fsck.error setting. In case that the same key is listed in multiple