Re: [PATCH v2 05/21] t6030: generalize test to not rely on current implementation

Stephan Beyer writes: > The bisect algorithm allows different outcomes if, for example, > the number of commits between a good and a bad commit is even. > The current test relies on a specific behavior (for example, > the behavior of the halfway() implementation). By disabling > halfway(), some s

Re: [PATCH v2 05/21] t6030: generalize test to not rely on current implementation

On Sun, Apr 10, 2016 at 9:47 AM, Torsten Bögershausen wrote: > On 10.04.16 15:18, Stephan Beyer wrote: >> diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh >> @@ -10,36 +10,34 @@ exec > + if [ -f "$_file" ]; then > I know that the old code did the same, is there a chance >

Re: [PATCH v2 05/21] t6030: generalize test to not rely on current implementation

On 04/10/2016 09:16 PM, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> Portabily: >> Since yesterday/yesterweek the usage of hard-coded >> #!/bin/sh had shown to be problematic > > That is not a new revelation, though ;-) It is just that these are > problematic to those on minority pl

Re: [PATCH v2 05/21] t6030: generalize test to not rely on current implementation

Torsten Bögershausen writes: > Portabily: > Since yesterday/yesterweek the usage of hard-coded > #!/bin/sh had shown to be problematic That is not a new revelation, though ;-) It is just that these are problematic to those on minority platforms, and by definition they are noticed only when a ver

Re: [PATCH v2 05/21] t6030: generalize test to not rely on current implementation

On 10.04.16 15:18, Stephan Beyer wrote: Some nit-comments inline > --- > t/t6030-bisect-porcelain.sh | 167 > ++-- > 1 file changed, 85 insertions(+), 82 deletions(-) > > diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh > index 05bc6

[PATCH v2 05/21] t6030: generalize test to not rely on current implementation

The bisect algorithm allows different outcomes if, for example, the number of commits between a good and a bad commit is even. The current test relies on a specific behavior (for example, the behavior of the halfway() implementation). By disabling halfway(), some skip tests fail although the algori