Re: [PATCH v2 06/10] t7006: add tests for how git tag paginates

2017-07-31 Thread Martin Ågren
On 31 July 2017 at 18:37, Junio C Hamano wrote: > Jeff King writes: > >> But here... >> >>> +test_expect_success TTY 'git tag -a respects pager.tag' ' >>> +test_when_finished "git tag -d newtag" && >>> +rm -f paginated.out && >>> +test_terminal git -c pager.tag tag -am message newtag

Re: [PATCH v2 06/10] t7006: add tests for how git tag paginates

2017-07-31 Thread Junio C Hamano
Jeff King writes: > But here... > >> +test_expect_success TTY 'git tag -a respects pager.tag' ' >> +test_when_finished "git tag -d newtag" && >> +rm -f paginated.out && >> +test_terminal git -c pager.tag tag -am message newtag && >> +test -e paginated.out >> +' > > I think this be

Re: [PATCH v2 06/10] t7006: add tests for how git tag paginates

2017-07-30 Thread Jeff King
On Mon, Jul 17, 2017 at 10:10:48PM +0200, Martin Ågren wrote: > diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh > index 20b4d83c2..e7430bc93 100755 > --- a/t/t7006-pager.sh > +++ b/t/t7006-pager.sh > @@ -134,6 +134,74 @@ test_expect_success TTY 'configuration can enable pager > (from subdir)' '

[PATCH v2 06/10] t7006: add tests for how git tag paginates

2017-07-17 Thread Martin Ågren
Using, e.g., `git -c pager.tag tag -a new-tag` results in errors such as "Vim: Warning: Output is not to a terminal" and a garbled terminal. A user who makes use of `git tag -a` and `git tag -l` will probably choose not to configure `pager.tag` or to set it to "no", so that `git tag -a` will actual