[PATCH v2 07/12] utf8: keep NULs in reencode_string()

2013-03-30 Thread Nguyễn Thái Ngọc Duy
reencode_string() will be used in the next patch for re-encoding pretty output, which can contain NULs. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/fast-export.c| 3 ++- builtin/mailinfo.c | 3 ++- compat/precompose_utf8.c | 2 +- notes.c | 4

Re: [PATCH v2 07/12] utf8: keep NULs in reencode_string()

2013-03-30 Thread Torsten Bögershausen
On 30.03.13 10:35, Nguyễn Thái Ngọc Duy wrote: [...] The short version of a review: Would it make sense to leave reencode_string() as it is, and add a new function reencode_string_len() +char *reencode_string_len(const char *in, int insz, + const char *out_encoding, const

Re: [PATCH v2 07/12] utf8: keep NULs in reencode_string()

2013-03-30 Thread Duy Nguyen
On Sun, Mar 31, 2013 at 12:06 AM, Torsten Bögershausen tbo...@web.de wrote: On 30.03.13 10:35, Nguyễn Thái Ngọc Duy wrote: [...] The short version of a review: Would it make sense to leave reencode_string() as it is, and add a new function reencode_string_len() Hmm.. yeah. +char