Re: [PATCH v2 08/14] sequencer: lib'ify read_and_refresh_cache()

2016-08-30 Thread Johannes Schindelin
Hi Junio, On Mon, 29 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Instead of dying there, let the caller high up in the callchain > > notice the error and handle it (by dying, still). > > > > There are two call sites of

Re: [PATCH v2 08/14] sequencer: lib'ify read_and_refresh_cache()

2016-08-29 Thread Junio C Hamano
Johannes Schindelin writes: > Instead of dying there, let the caller high up in the callchain > notice the error and handle it (by dying, still). > > There are two call sites of read_and_refresh_cache(), one of which is > pick_commits(), whose callers were already

[PATCH v2 08/14] sequencer: lib'ify read_and_refresh_cache()

2016-08-26 Thread Johannes Schindelin
Instead of dying there, let the caller high up in the callchain notice the error and handle it (by dying, still). There are two call sites of read_and_refresh_cache(), one of which is pick_commits(), whose callers were already prepared to do the right thing given an "error" return from it by an