Re: [PATCH v2 08/21] bisect: report on fopen() error

2017-05-03 Thread Johannes Schindelin
Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > The main thing to catch here is when fopen() is called on a > directory. It's safe even without this change because a few lines > earlier we do check if "filename" is a regular file. > > Regardless, let's stay on the safe side in case

[PATCH v2 08/21] bisect: report on fopen() error

2017-05-03 Thread Nguyễn Thái Ngọc Duy
The main thing to catch here is when fopen() is called on a directory. It's safe even without this change because a few lines earlier we do check if "filename" is a regular file. Regardless, let's stay on the safe side in case somebody changes those lines. Unconditionally printing to stderr by