Re: [PATCH v2 09/15] config: avoid using the global variable `store`

Hi Peff, On Fri, 6 Apr 2018, Jeff King wrote: > On Tue, Apr 03, 2018 at 06:28:34PM +0200, Johannes Schindelin wrote: > > > -static struct { > > +struct config_set_store { > > This made me think of the existing "configset", which is quite a > different thing. Maybe just "config_store_data" or so

Re: [PATCH v2 09/15] config: avoid using the global variable `store`

On Tue, Apr 03, 2018 at 06:28:34PM +0200, Johannes Schindelin wrote: > It is much easier to reason about, when the config code to set/unset > variables or to remove/rename sections does not rely on a global (or > file-local) variable. Agreed. > -static struct { > +struct config_set_store { This

[PATCH v2 09/15] config: avoid using the global variable `store`

It is much easier to reason about, when the config code to set/unset variables or to remove/rename sections does not rely on a global (or file-local) variable. Signed-off-by: Johannes Schindelin --- config.c | 119 +++ 1 file changed, 6