Re: [PATCH v2 09/16] tag: add more incompatibles mode tests

2017-03-21 Thread Ævar Arnfjörð Bjarmason
On Tue, Mar 21, 2017 at 7:32 PM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Amend the test suite to test for more invalid uses like "-l -a" >> etc. This mainly tests the `(argc == 0 && !cmdmode)` -> >> `((create_tag_object || force) && (cmdmode != 0))` code path in >> builtin/t

Re: [PATCH v2 09/16] tag: add more incompatibles mode tests

2017-03-21 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Amend the test suite to test for more invalid uses like "-l -a" > etc. This mainly tests the `(argc == 0 && !cmdmode)` -> > `((create_tag_object || force) && (cmdmode != 0))` code path in > builtin/tag.c. The second sentence is now stale, isn't it? > > Signed-

[PATCH v2 09/16] tag: add more incompatibles mode tests

2017-03-21 Thread Ævar Arnfjörð Bjarmason
Amend the test suite to test for more invalid uses like "-l -a" etc. This mainly tests the `(argc == 0 && !cmdmode)` -> `((create_tag_object || force) && (cmdmode != 0))` code path in builtin/tag.c. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/t7004-tag.sh | 13 + 1 file changed, 13