Re: [PATCH v2 1/2] commit-graph write: add progress output

2018-09-21 Thread Junio C Hamano
Junio C Hamano writes: >> The above prototype change seems to have created a semantic conflict >> with ds/commit-graph-tests (859fdc "commit-graph: define >> GIT_TEST_COMMIT_GRAPH") because when GIT_TEST_COMMIT_GRAPH is set, we >> call write_commit_graph_reachable() but the final parameter was

Re: [PATCH v2 1/2] commit-graph write: add progress output

2018-09-21 Thread Junio C Hamano
Derrick Stolee writes: > On 9/7/2018 2:29 PM, Ævar Arnfjörð Bjarmason wrote: >> -void write_commit_graph_reachable(const char *obj_dir, int append); >> +void write_commit_graph_reachable(const char *obj_dir, int append, >> + int report_progress); >> void

Re: [PATCH v2 1/2] commit-graph write: add progress output

2018-09-21 Thread Derrick Stolee
On 9/7/2018 2:29 PM, Ævar Arnfjörð Bjarmason wrote: -void write_commit_graph_reachable(const char *obj_dir, int append); +void write_commit_graph_reachable(const char *obj_dir, int append, + int report_progress); void write_commit_graph(const char *obj_dir,

[PATCH v2 1/2] commit-graph write: add progress output

2018-09-07 Thread Ævar Arnfjörð Bjarmason
Before this change the "commit-graph write" command didn't report any progress. On my machine this command takes more than 10 seconds to write the graph for linux.git, and around 1m30s on the 2015-04-03-1M-git.git[1] test repository (a test case for a large monorepository). Furthermore, since the