Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-17 Thread Junio C Hamano
Michael Haggerty writes: > I think the logic should be > > if test_have_prereq POSIXPERM && test -x "$1/config" > > , right? Yeah ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-17 Thread Michael Haggerty
On 11/17/2014 04:42 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> This seems like a one-off bug caused by a specific instance of odd code. >> It could only recur if somebody were to remove the line that I added, >> which would be a *very* odd mistake to make given that its purpose is

Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-17 Thread Junio C Hamano
Michael Haggerty writes: > This seems like a one-off bug caused by a specific instance of odd code. > It could only recur if somebody were to remove the line that I added, > which would be a *very* odd mistake to make given that its purpose is > pretty obvious. Or some other code that comes _aft

Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-17 Thread Michael Haggerty
On 11/17/2014 10:08 AM, Torsten Bögershausen wrote: > On 11/17/2014 02:40 AM, Eric Sunshine wrote: >> On Sun, Nov 16, 2014 at 2:21 AM, Michael Haggerty >> wrote: >>> [...] > Sorry for the late reply, I actually had prepared a complete different > patch > for a different problem, but it touches the

Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-17 Thread Michael Haggerty
On 11/17/2014 02:40 AM, Eric Sunshine wrote: > On Sun, Nov 16, 2014 at 2:21 AM, Michael Haggerty > wrote: >> Since time immemorial, the test of whether to set "core.filemode" has >> been done by trying to toggle the u+x bit on $GIT_DIR/config and then >> testing whether the change "took". It is s

Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-17 Thread Michael Haggerty
On 11/16/2014 08:08 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> Since time immemorial, the test of whether to set "core.filemode" has >> been done by trying to toggle the u+x bit on $GIT_DIR/config and then >> testing whether the change "took". It is somewhat odd to use the >> confi

Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-17 Thread Torsten Bögershausen
On 11/17/2014 02:40 AM, Eric Sunshine wrote: On Sun, Nov 16, 2014 at 2:21 AM, Michael Haggerty wrote: Since time immemorial, the test of whether to set "core.filemode" has been done by trying to toggle the u+x bit on $GIT_DIR/config and then testing whether the change "took". It is somewhat odd

Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-16 Thread Eric Sunshine
On Sun, Nov 16, 2014 at 2:21 AM, Michael Haggerty wrote: > Since time immemorial, the test of whether to set "core.filemode" has > been done by trying to toggle the u+x bit on $GIT_DIR/config and then > testing whether the change "took". It is somewhat odd to use the > config file for this test, b

Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-16 Thread Junio C Hamano
Michael Haggerty writes: > Since time immemorial, the test of whether to set "core.filemode" has > been done by trying to toggle the u+x bit on $GIT_DIR/config and then > testing whether the change "took". It is somewhat odd to use the > config file for this test, but whatever. The last sentence

[PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

2014-11-15 Thread Michael Haggerty
Since time immemorial, the test of whether to set "core.filemode" has been done by trying to toggle the u+x bit on $GIT_DIR/config and then testing whether the change "took". It is somewhat odd to use the config file for this test, but whatever. The test code didn't set the u+x bit back to its ori